Skip to content

CHANGE: Exposes internals to the Unity AI Assistant #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

CHANGE: Exposes internals to the Unity AI Assistant #2250

merged 1 commit into from
Oct 3, 2025

Conversation

AndrewTHEManeri
Copy link
Contributor

Description

The AI Assistant need access to the EditorInputControlLayoutCache for proper input support. The class is internal so this PR just opens up the internals to the AI assembly.

Testing status & QA

Run automated tests, tested Input tool on AI side.

Overall Product Risks

Low

Comments to reviewers

High priority

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@AndrewTHEManeri
Exposes internals to the Unity AI Assistant
44a2cc7 
AI assistant needs access to the EditorInputControlLayoutCache for proper input support
@AndrewTHEManeri AndrewTHEManeri requested a review from ekcoh October 1, 2025 19:10
@codecov-github-com
Copy link

codecov-github-com bot commented Oct 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2250      +/-   ##
===========================================
- Coverage    76.70%   76.70%   -0.01%     
===========================================
  Files          465      465              
  Lines        87919    87919              
===========================================
- Hits         67442    67436       -6     
- Misses       20477    20483       +6
Flag Coverage Δ
inputsystem_MacOS_2021.3 5.91% <ø> (ø)
inputsystem_MacOS_2021.3_project 78.05% <ø> (ø)
inputsystem_MacOS_2022.3 5.37% <ø> (ø)
inputsystem_MacOS_2022.3_project 74.58% <ø> (ø)
inputsystem_MacOS_6000.0 5.19% <ø> (ø)
inputsystem_MacOS_6000.0_project 76.50% <ø> (ø)
inputsystem_MacOS_6000.2 5.19% <ø> (ø)
inputsystem_MacOS_6000.2_project 76.50% <ø> (ø)
inputsystem_MacOS_6000.3 5.19% <ø> (ø)
inputsystem_MacOS_6000.3_project 76.50% <ø> (ø)
inputsystem_MacOS_6000.4 5.19% <ø> (ø)
inputsystem_MacOS_6000.4_project 76.50% <ø> (ø)
inputsystem_Ubuntu_2021.3 5.91% <ø> (ø)
inputsystem_Ubuntu_2021.3_project 77.96% <ø> (ø)
inputsystem_Ubuntu_2022.3 5.38% <ø> (ø)
inputsystem_Ubuntu_2022.3_project 74.39% <ø> (ø)
inputsystem_Ubuntu_6000.0 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 76.32% <ø> (ø)
inputsystem_Ubuntu_6000.2 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.2_project 76.32% <ø> (ø)
inputsystem_Ubuntu_6000.3 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 76.31% <ø> (ø)
inputsystem_Ubuntu_6000.4 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 76.31% <ø> (-0.01%) ⬇️
inputsystem_Windows_2021.3 5.91% <ø> (ø)
inputsystem_Windows_2021.3_project 78.20% <ø> (ø)
inputsystem_Windows_2022.3 5.37% <ø> (ø)
inputsystem_Windows_2022.3_project 74.72% <ø> (ø)
inputsystem_Windows_6000.0 5.19% <ø> (ø)
inputsystem_Windows_6000.0_project 76.64% <ø> (ø)
inputsystem_Windows_6000.2 5.19% <ø> (ø)
inputsystem_Windows_6000.2_project 76.64% <ø> (ø)
inputsystem_Windows_6000.3 5.19% <ø> (ø)
inputsystem_Windows_6000.3_project 76.64% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.4 5.19% <ø> (ø)
inputsystem_Windows_6000.4_project 76.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndrewTHEManeri AndrewTHEManeri changed the title Exposes internals to the Unity AI Assistant CHANGE: Exposes internals to the Unity AI Assistant Oct 1, 2025
@Pauliusd01 Pauliusd01 merged commit 38aa26e into develop Oct 3, 2025
129 of 133 checks passed
@Pauliusd01 Pauliusd01 deleted the ai-assistant_cache_access branch October 3, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekcoh ekcoh ekcoh approved these changes

@jfreire-unity jfreire-unity jfreire-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewTHEManeri @ekcoh @jfreire-unity @Pauliusd01